Skip to content

Update the container registry examples for steps.uses#1121

Merged
jmarlena merged 14 commits intogithub:mainfrom
varunsridharan:patch-1
Feb 14, 2021
Merged

Update the container registry examples for steps.uses#1121
jmarlena merged 14 commits intogithub:mainfrom
varunsridharan:patch-1

Conversation

@varunsridharan
Copy link
Copy Markdown
Contributor

@varunsridharan varunsridharan commented Nov 6, 2020 •
edited by martin389
Loading

Why:

"Example using a Docker public registry action" needs to explain which container registry is being demonstrated.

What's being changed:

Check off the following:

@varunsridharan
Fixed Github's Container Registry Domain
a62e908 
changed `gcr.io` to `ghcr.io` because `gcr.io` is an invalid domain to fetch Github's container registry.
@welcome
Copy link
Copy Markdown

welcome Bot commented Nov 6, 2020

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

nschonni
nschonni reviewed Nov 6, 2020
View reviewed changes
Comment thread content/actions/reference/workflow-syntax-for-github-actions.md Outdated
@janiceilene
Copy link
Copy Markdown
Contributor

janiceilene commented Nov 6, 2020

Thanks so much for opening a PR @varunsridharan! I'll get this triaged for review 🎉

@janiceilene janiceilene added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team labels Nov 6, 2020
@varunsridharan
Copy link
Copy Markdown
Contributor Author

varunsridharan commented Nov 7, 2020

@janiceilene I have updated the docs once again with example on how to use from Github Container Registry & Public Registry

@varunsridharan varunsridharan deleted the patch-1 branch November 12, 2020 04:28
@varunsridharan varunsridharan restored the patch-1 branch November 12, 2020 04:28
@varunsridharan
Copy link
Copy Markdown
Contributor Author

varunsridharan commented Nov 12, 2020

Deleted Pull Request Branch By Mistake. Re-opening for review.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 19, 2020

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions Bot added the stale There is no recent activity on this issue or pull request label Nov 19, 2020
@varunsridharan
Copy link
Copy Markdown
Contributor Author

varunsridharan commented Nov 20, 2020

@janiceilene any update on this ? will this ever be reviewed ?

@github-actions github-actions Bot removed the stale There is no recent activity on this issue or pull request label Nov 20, 2020
@janiceilene
Copy link
Copy Markdown
Contributor

janiceilene commented Nov 20, 2020

Thanks for your patience @varunsridharan! Our small team is working our way through all of the amazing contributions and this PR is triaged for review.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Nov 28, 2020

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions Bot added the stale There is no recent activity on this issue or pull request label Nov 28, 2020
@varunsridharan
Copy link
Copy Markdown
Contributor Author

varunsridharan commented Nov 30, 2020

@github-openapi-bot still waiting 😄

@github-actions github-actions Bot removed the stale There is no recent activity on this issue or pull request label Nov 30, 2020
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 8, 2020

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions Bot added the stale There is no recent activity on this issue or pull request label Dec 8, 2020
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Dec 8, 2020
martin389
martin389 reviewed Dec 10, 2020
View reviewed changes
Comment thread content/actions/reference/workflow-syntax-for-github-actions.md Outdated
varunsridharan and others added 2 commits December 10, 2020 11:38
@varunsridharan @martin389
Update content/actions/reference/workflow-syntax-for-github-actions.md
dd229d1 
Co-authored-by: Martin Lopes <54248166+martin389@users.noreply.github.com>
@varunsridharan
Merge branch 'main' into patch-1
3b89ed8
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Dec 26, 2020

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions Bot added the stale There is no recent activity on this issue or pull request label Dec 26, 2020
@martin389
Copy link
Copy Markdown
Contributor

martin389 commented Dec 28, 2020

Following up with support folks

@github-actions github-actions Bot removed the stale There is no recent activity on this issue or pull request label Dec 28, 2020
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 5, 2021

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions Bot added the stale There is no recent activity on this issue or pull request label Jan 5, 2021
@janiceilene janiceilene removed the stale There is no recent activity on this issue or pull request label Jan 5, 2021
@martin389
Copy link
Copy Markdown
Contributor

martin389 commented Jan 8, 2021

Following up with support folks ❤️

@martin389
Copy link
Copy Markdown
Contributor

martin389 commented Jan 14, 2021

Support folks have confirmed they are reviewing.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 1, 2021

This PR is stale because it has been open 7 days with no activity and will be automatically closed in 3 days. To keep this PR open, update the PR by adding a comment or pushing a commit.

@github-actions github-actions Bot added the stale There is no recent activity on this issue or pull request label Feb 1, 2021
@janiceilene janiceilene added waiting for review Issue/PR is waiting for a writer's review and removed stale There is no recent activity on this issue or pull request labels Feb 1, 2021
@varunsridharan
Copy link
Copy Markdown
Contributor Author

varunsridharan commented Feb 11, 2021

Still Waiting for Review !! ?

@martin389
Copy link
Copy Markdown
Contributor

martin389 commented Feb 11, 2021

Sorry about the delay @varunsridharan! I've confirmed that this is in the queue for a review 👍

@martin389 martin389 assigned jmarlena and unassigned martin389 Feb 11, 2021
jmarlena
jmarlena previously approved these changes Feb 14, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jmarlena jmarlena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@varunsridharan Thanks for your patience and sorry for the delay in reviewing this PR.

I added some versioning around the ghcr.io mention but otherwise this should be ready to merge!

Comment thread content/actions/reference/workflow-syntax-for-github-actions.md
Comment thread content/actions/reference/workflow-syntax-for-github-actions.md Outdated
@jmarlena jmarlena dismissed stale reviews from ghost and themself via 890ffb1 February 14, 2021 22:56
jmarlena
jmarlena approved these changes Feb 14, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jmarlena jmarlena left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an outstanding product question I have about container registry support in workflows but this can merge in the meantime since it's so small scope.

@jmarlena jmarlena merged commit 5997c2e into github:main Feb 14, 2021
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 14, 2021

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours.

jnidzwetzki pushed a commit to jnidzwetzki/docs that referenced this pull request Oct 6, 2022
@ericdwang
Fix broken Promscale link (github#1121)
31c2cfd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@nschonni nschonni nschonni left review comments

@martin389 martin389 martin389 left review comments

@jmarlena jmarlena jmarlena approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jmarlena jmarlena

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team ecosystem This issue or pull request should be reviewed by the Docs Ecosystem team waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@varunsridharan @janiceilene @martin389 @nschonni @jmarlena